[Webkit-unassigned] [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 17:25:29 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=34005


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55057|review?                     |review+
               Flag|                            |




--- Comment #66 from Anders Carlsson <andersca at apple.com>  2010-05-05 17:25:28 PST ---
(From update of attachment 55057)
WebCore/platform/graphics/win/QTMovieVisualContext.cpp:76
 +          pPixelBufferContextCreate =
reinterpret_cast<pfnQTPixelBufferContextCreate>(GetProcAddress(qtmlDLL,
"QTPixelBufferContextCreate"));
Add :: to the GetProcAddress call like you did with LoadLibraryW.

WebCore/platform/graphics/win/QTPixelBuffer.cpp:68
 +      m_pixelBuffer = ref;
If you want to, you could return early if ref == m_pixelBuffer.

(I don't feel strongly about it though).


Looks great otherwise, r=me!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list