[Webkit-unassigned] [Bug 38566] [WTFURL] Add a class to represent the segments of a URL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 16:32:36 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38566





--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-05-05 16:32:35 PST ---
> If this code expects to be advancing past a specific character, perhaps an
> ASSERT would be a better way to document that than a comment.

The string isn't available here (because it's stored separately from the
segmentation), so we can't actually assert that here.

> r- for now to address the above issues. None of them are showstoppers, but it
> seems like there are enough different comments to warrant a new patch version.

I've addressed the remainder.  I'll be more agressive about making the comments
more WebKit-like in future patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list