[Webkit-unassigned] [Bug 26382] [ES5] Implement Function.prototype.bind

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 15:32:45 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=26382


Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54898|0                           |1
        is obsolete|                            |




--- Comment #18 from Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org>  2010-05-05 15:32:43 PST ---
Created an attachment (id=55161)
 --> (https://bugs.webkit.org/attachment.cgi?id=55161)
Optimization for bind() used just for binding 'this' (JIT case), v2

This an improvement of earlier implementation of the JIT rewriting
optimization.

Functionally it should be complete, still have a FIXME to check and possibly
removing a redundant information passed to the stub. Note that I'm still
working only in one case of Call until we settle in a solution.

After some tests and discussion with Oliver, we understood that it was not
always safe to rewrite the register containing the 'callee' since it could be a
non-temporary register. The solution in this patch is to force every call
emitted to use a temporary for 'callee'. This causes impact on the size of
bytecode generated, but guarantee that it's safe to rewrite the call frame,
making the optimization correct.

I still want to give a different take on optimizing this case, and try to
save/restore the 'callee' instead of guarantee that it is always a temporary.
Then compare both solutions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list