[Webkit-unassigned] [Bug 38602] Page::setCanStartMedia does not properly handle the case where a media listener is removed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38602





--- Comment #4 from Darin Adler <darin at apple.com>  2010-05-05 12:50:48 PST ---
(In reply to comment #3)
> (From update of attachment 55144 [details])
> > @@ -422,8 +422,11 @@ void Page::setCanStartMedia(bool canStar
> >      m_mediaCanStartListeners.clear();
> >  
> >      size_t size = listeners.size();
> > -    for (size_t i = 0; i < size; ++i)
> > -        listeners[i]->mediaCanStart();
> > +    for (size_t i = 0; i < size; ++i) {
> > +        MediaCanStartListener* listener = listeners[i];
> > +        if (m_mediaCanStartListeners.contains(listener))'
> 
> Won't this test always fail, since line 422 cleared out
> m_mediaCanStartListeners?

Yes, that's right. Need a bigger change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.