[Webkit-unassigned] [Bug 38561] new-run-webkit-tests should check each thread for exceptions instead of just the first one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38561





--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2010-05-05 09:55:07 PST ---
> > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:712
> >  +                  # If we got any exception, tear down all threads.
> > We're in a finally clause here. We don't know that we got an exception. I think
> > you mean this to be an except clause?
> 
> No, this is also intentional.  Basically if you ever leave that while loop, all
> threads should be canceled.  That code makes sure that's the case.  I could
> except, cancel and then re raise, that would be equivalent since
> thread.cancel() on a completed thread does nothing.

Maybe I'm missing something. For this to work right, doesn't the while loop
itself need to be inside the try instead of the try being in the while loop?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.