[Webkit-unassigned] [Bug 38561] new-run-webkit-tests should check each thread for exceptions instead of just the first one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38561





--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2010-05-05 08:08:12 PST ---
(From update of attachment 55087)
WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:246
 +  class ThreadTimings(object):
I really like that you've made this a class. I'm a bit sad that you've deleted
the comments explaining what each of the member variables are. I had to go read
the old comments to confirm this code is  correct.

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:675
 +              print "\nlogging._lock: %s\n" % logging._lock
Probably should use logging.debug?

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:705
 +                      # and any not-yet-run tests should cannot be assumed to
pass.
should cannot?

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:706
 +                      thread.reraise_exception()
This is a change in behavior. It means we fail early if a thread has an error.
I think that's better though.

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:712
 +                  # If we got any exception, tear down all threads.
We're in a finally clause here. We don't know that we got an exception. I think
you mean this to be an except clause?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.