[Webkit-unassigned] [Bug 38531] V8 ScriptCallStack does not build on Android due to missing feature guards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38531





--- Comment #10 from jaimeyap at google.com  2010-05-05 07:31:15 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Actually, Jaime is almost done with his v8 refactoring that allows capturing
> > javascript stack without the need in utility context. Why don't we land first
> > version of your patch now and get rid of the context as a whole in few days
> > (once new stack-related code lands into v8 and rolls into the build)?
> > 
> > Jaime, could you confirm that you are about to land and that the utility
> > context will go away (at least from the ScriptCallStack)?
> 
> Yes. I am about to land a new StackTrace API to V8 bleeding edge. Should go in
> today or tomorrow depending on when I can get a committer.  See
> http://codereview.chromium.org/1694011/show
> 
> Yes, this means that I can remove the utility context entirely from
> ScriptDebugServer. I plan on updating
> https://bugs.webkit.org/show_bug.cgi?id=37502 to use that API and in the
> process resolve this bug.
> 
> I think we should wait until bleeding edge V8 gets merged to trunk and that
> gets deps rolled into Chromium before updating webkit. This should happen I
> think by Friday. But I will try and submit the updated WebKit patch for review
> sometime today.

To clarify, after catching up on this bug, I agree with Pavel. Land this now to
remove the utility context from ScriptDebugServer.

I will follow up later to use the new stack trace API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.