[Webkit-unassigned] [Bug 38557] r58526 introduced a ~30% regression on Dromaeo JS lib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38557





--- Comment #1 from anton muhin <antonm at chromium.org>  2010-05-05 07:12:33 PST ---
Gavin, sorry for introducing that.

What is interesting there is nothing like that for Chromium:
http://build.chromium.org/buildbot/perf/xp-release-single-core/dromaeo_jslib/report.html?history=350&header=&thumbnail=undefined&rev=-1&graph=jslib_traverse_prototype 

The only difference between Safari and Chromium that immediately come into my
mind is change to GC policy---I haven't yet implemented retention of cached
node lists in v8's bindings (will implement this week).

Gavin, if you have some spare cycles, may I ask you to comment out GC thing
(this is the only change in JSNodeCustom.cpp:
http://trac.webkit.org/changeset/58526/trunk/WebCore/bindings/js/JSNodeCustom.cpp)
and check if it solves the problem?

If you don't have any cycles, just let me know and I'll investigate.

If possible, I'd ask not to revert it for, say, a week---I'll start working on
it immediately.

And just for your information: there is a pretty convenient way to compare
several Dromaeo runs---just separate run ids with comma:
http://dromaeo.com/?id=102238,102247

(In reply to comment #0)
> This change -> http://trac.webkit.org/changeset/58526
> 
> Regressed Dromaeo JS lib tests by ~30% on my machine.  That said, it was about
> an equally huge win on Dromaeo DOM core (awesome!), but given our
> no-regressions policy I'd imagine we'll need to find a way to avoid the
> performance hit if we are to keep this in the tree.  Might be best to revert &
> re-land a new patch, once this issue has been resolved?
> 
> The hit seems to mostly fall on the CSS style & DOM traversal tests.
> 
> http://dromaeo.com/?id=102238
> http://dromaeo.com/?id=102247
> 
> Darin, cc'ing you as reviewer of the original patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.