[Webkit-unassigned] [Bug 38531] V8 ScriptCallStack does not build on Android due to missing feature guards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38531





--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-05-05 02:48:19 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > This is Ok short term so that you could have the build compiled. However,
> > > longer term, I think we should move topStackFrame to the ScriptCallStack so
> > > that you did not lose console API functions.
> > Thanks for the comments Pavel. I've updated my patch to reflect this. There's
> > no huge rush to fix the Android build, as we don't sync too regularly.
> 
> One thing that concerns me ... 

oops - was adding Jaime to the CC list.

So the thing that concerns me now is that it pulled everything together with
utility context into the stack class. Initially, utility context lived in the
V8Proxy and was used for the debugging needs mostly. At that time I suggested
Jaime moving it into the newly create ScriptDebugServer class, but I did not
realize ports might want to use console traces and not have javascript
debugging enabled back then. It looks like this is the case though, so we might
need to move utility context back to the v8 proxy, call it debugger context and
use from ScriptDebugServer and this call stack class. I realize that it is too
much to ask from you, so I am happy to fix it myself!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.