[Webkit-unassigned] [Bug 37848] WCSS: -wap-input-format and -wap-input-required not supported.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37848





--- Comment #20 from Charles Wei <charles.wei at torchmobile.com.cn>  2010-05-05 02:32:09 PST ---
(In reply to comment #19)
> (From update of attachment 54992 [details])
> Rejecting patch 54992 from commit-queue.
> 
> Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
> Last 500 characters of output:
> ment.h
>     M    WebKitTools/ChangeLog
>     M    WebKitTools/Scripts/old-run-webkit-tests
>     M    WebKitTools/Scripts/webkitperl/features.pm
> A repository hook failed: MERGE request failed on '/repository/webkit/trunk':
> Commit blocked by pre-commit hook (exit code 1) with output:
> svnlook: Can't write to stream: Broken pipe
> 
>     The following ChangeLog files contain OOPS:
> 
>         trunk/WebKitTools/ChangeLog
> 
>     Please don't ever say "OOPS" in a ChangeLog file.
>  at /usr/local/git/libexec/git-core/git-svn line 570
> 
> 
> Full output: http://webkit-commit-queue.appspot.com/results/2109031



That's really frustrating.  I submitted many patches before, all with "Reviewed
by NOBODY(OOPS!)",  and they were landed.    When I submit my patch , I don't
know who is going to review it and land it , so I have to leave it there.

Here's what the it say at http://webkit.org/coding/contributing.html:

ChangeLog files
ChangeLogs are simple text files which provide historical documentation for all
changes to the WebKit project. ...  Don't worry about the "Reviewed by NOBODY
(OOPS!)" line, the person landing your patch will fill this in.


I suppose the submitter is not supposed to change that ?  Please elaborate who
is going to replace the "OOPs".

Thanks 

Charles

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.