[Webkit-unassigned] [Bug 38567] Web Inspector: FontView needs Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 00:25:31 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38567


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55093|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2010-05-05 00:25:29 PST ---
Created an attachment (id=55093)
 --> (https://bugs.webkit.org/attachment.cgi?id=55093)
[PATCH] Proposed Fix - FontView Cleanup

The patch looks a lot scarier then it actually is.

- moved some code down from the constructor to contentTabSelected
- changed some variables to const for clarity
- cached the number of lines in this._lineCount (we may need to remove this if
we allow the users to edit the text on the fly! see bug 16232!)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list