[Webkit-unassigned] [Bug 38477] Login Popup for Adobe ID loops forever in nightly builds due to an incorrect version check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 22:17:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38477


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REGRESSION: Login Popup for |Login Popup for Adobe ID
                   |Adobe ID loops forever      |loops forever in nightly
                   |                            |builds due to an incorrect
                   |                            |version check
           Platform|Macintosh Intel             |All
         OS/Version|Mac OS X 10.6               |All
           Keywords|NeedsReduction, Regression  |HasReduction
           Priority|P1                          |P2
          Component|Forms                       |Evangelism




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2010-05-04 22:17:40 PST ---
This is a site bug - there is a version check for "supported browsers" that
fails for nightlies because there is a plus sign in version number, and a
fallback code path for unsupported browsers that's just broken. I tested that
the fallback also doesn't work in Firefox (with a custom user agent string).

    // Regexes to check for supported browsers:
    // Firefox 2/3, IE6/7/8, Safari 3, Google Chrome
    var sBrowsers = [
        "Gecko/[0-9.]+ Firefox/(2|3)[0-9.]+",
        "MSIE (6|7|8)",
        "AppleWebKit/[0-9.]+ \\(KHTML, like Gecko\\) (Version|Chrome)/[0-9.]+
Safari/[0-9.]+"
    ];

To evangelism.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list