[Webkit-unassigned] [Bug 37743] Remove dependency of jsCurrentTime() on currentTime()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37743





--- Comment #16 from Leo Yang <leo.yang at torchmobile.com.cn>  2010-05-04 18:35:47 PST ---
(In reply to comment #15)
> (From update of attachment 54996 [details])
> This seems to break the build on every platform.
> 
> Maybe you could break this up into multiple patches. One could change the calls
> at all the call sites and so be entirely mechanical.
> 
> The part of this that needs careful review is that we have to figure out at
> each call site if it's OK to use the monotonic time rather than the clock time.
> It would be good to review those carefully a few at a time instead of in a
> single giant patch. Perhaps the first patch would be to convert all the call
> sites where it's very clear and completely obvious which to use.
agree!

How to break to multiple patches? Perhaps I would keep currentTime() &
currentTimeMS() and add monotonicTime() & currentUTCTime() &
currentUTCTimeMS(), then change some call sites and submit a patch, and then
change some other call sites and submit a patch, ...., in the last patch,
remove currentTime() & currentTimeMS(). Would it be ok?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.