[Webkit-unassigned] [Bug 38158] Fix gcc compiler warnings in chromium platform graphics code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38158


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agl at chromium.org,
                   |                            |evan at chromium.org,
                   |                            |jamesr at chromium.org




--- Comment #8 from James Robinson <jamesr at chromium.org>  2010-05-04 17:02:11 PST ---
This was reverted because this snippet:
  if (x < walker.width())
in FontLinux.cpp would evaluate to false if 'x' was less than 'walker.width()'
or if 'x' was negative, because walker.width() returned an unsigned value.  C's
type promotion rules would promote a negative 'x' to a large positive integer. 
I've changed walker.width() to return a signed value and changed this statement
to:
  if (x >= 0 && x < walker.width())

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.