[Webkit-unassigned] [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34005





--- Comment #61 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-05-04 15:36:49 PST ---
Attachment 55054 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
exit_code: 1
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:26: 
#ifndef header guard has wrong style, please use:
MediaPlayerPrivateQuickTimeVisualContext_h  [build/header_guard] [5]
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:29: 
Found other header before a header this file implements. Should be: config.h,
primary header, blank line, and then alphabetically sorted. 
[build/include_order] [4]
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:31: 
Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:57: 
"FrameView.h" already included at
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:34 
[build/include] [4]
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:58: 
"Frame.h" already included at
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:33 
[build/include] [4]
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:59: 
Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:391:
 Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:905:
 Extra space before last semicolon. If this should be an empty statement, use {
} instead.  [whitespace/semicolon] [5]
Total errors found: 8 in 2 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.