[Webkit-unassigned] [Bug 38537] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38537


qi <qi.2.zhang at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55035|                            |review?
               Flag|                            |




--- Comment #1 from qi <qi.2.zhang at nokia.com>  2010-05-04 12:00:21 PST ---
Created an attachment (id=55035)
 --> (https://bugs.webkit.org/attachment.cgi?id=55035)
patch

For path.arc, there are some special case need to handle:
1> If the anticlockwise argument is false and endAngle-startAngle is equal to
or greater than 2π, or, if the
anticlockwise argument is true and startAngle-endAngle is equal to or greater
than 2π, then the arc is the whole
circumference of this circle.
   Otherwise, the arc is the path along the circumference of this circle from
the start point to the end point, going
anti-clockwise if the anticlockwise argument is true, and clockwise otherwise.
Since the points are on the circle, as
opposed to being simply angles from zero, the arc can never cover an angle
greater than 2π radians.

   Currently, our span can be bigger than 2π, this is wrong.

2> If the context has any
subpaths, then the method must add a straight line from the last point in the
subpath to the start point of the arc.

   Currently, we always add a line, didn't check if has any subpaths.
3> When span is 0, QPainterPath still draw something, the behavior is different
with required.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.