[Webkit-unassigned] [Bug 38220] [chromium] Add API for querying whether a WebWidget is using GPU accelerated compositing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 11:05:52 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38220


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54969|review?                     |review-
               Flag|                            |




--- Comment #15 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-05-04 11:05:51 PST ---
(From update of attachment 54969)
WebKit/chromium/public/WebPopupMenu.h:44
> +      virtual bool isAcceleratedCompositingActive() const = 0;
You can delete this line as WebPopupMenu inherits from WebWidget.

WebKit/chromium/src/WebPopupMenuImpl.h:82
> +      virtual bool isAcceleratedCompositingActive() const { return false; }
please create a separate section labelled WebPopupMenu and move this
method there.

the method declarations are grouped by interfaces being implemented.

otherwise, LGTM!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list