[Webkit-unassigned] [Bug 38468] REGRESSION: Text clipped in absolutely positioned search inputs

Mon May 3 21:59:41 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38468

mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54994|review?                     |review+
               Flag|                            |

--- Comment #17 from mitz at webkit.org  2010-05-03 21:59:41 PST ---
(From update of attachment 54994)
r=me

I can’t help commenting on something:

> +    ASSERT(m_innerBlock);
> +
> +    IntRect clipRect = IntRect(m_innerBlock->renderBox()->frameRect());

In my opinion, asserting that a pointer is not null is pointless if you are
immediately going to dereference the pointer—you will crash anyway and you’ll
be able to tell why. But maybe others think differently.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.