[Webkit-unassigned] [Bug 38468] REGRESSION: Text clipped in absolutely positioned search inputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38468





--- Comment #15 from Joseph Pecoraro <joepeck at webkit.org>  2010-05-03 21:41:08 PST ---
(In reply to comment #13)
> (From update of attachment 54984 [details])
> > +    IntRect clipRect = IntRect(renderBox->x(), max(borderTop() + paddingTop(), renderBox->y()), contentWidth(), contentHeight());        
> 
> Wouldn’t this lead to asymmetry between the case of (top padding with no bottom
> padding) and (bottom padding with no top padding)?

There would not be asymmetry because the "renderBox->y()" is a vertical center,
and so whether there is more top or more bottom padding the y location would be
set to the middle. That is unless the height of the innerBlock is already
greater than the height of the textfield, where centering does not apply.


> Anyway, looking at this again, and comparing with the behavior of <input
> type="text">, which uses overflow: hidden on the text block in order to clip
> (this is why it doesn’t need to have control clip), I now think that the case I
> last mentioned is not worth preserving, and that one should just clip to the
> inner block, which would be consistent with text fields.

Good to know. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.