[Webkit-unassigned] [Bug 38505] New: new-run-webkit-tests hung on Chromium Mac bot writing to files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38505

           Summary: new-run-webkit-tests hung on Chromium Mac bot writing
                    to files
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: tony at chromium.org, abarth at webkit.org, ojan at google.com,
                    dpranke at chromium.org
        Depends on: 38300


new-run-webkit-tests hung on Chromium Mac bot writing to files

http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/19185/steps/webkit_tests/logs/stdio
Copy of the log attached.

The interesting bits:

# Thread: -1341116416
File:
"/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/threading.py",
line 460, in __bootstrap
  self.run()
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 258, in run
  self._run(test_runner=None, result_summary=None)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 330, in _run
  result = self._run_test(test_info)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 439, in _run_test
  output, error)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 107, in process_output
  configuration)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py",
line 109, in compare_output
  print_text_diffs=True)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/test_types/test_type_base.py",
line 209, in write_output_files
  pretty_patch = port.pretty_patch_text(diff_filename)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py",
line 603, in pretty_patch_text
  return self._executive.run_command(command, decode_output=False)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/common/system/executive.py",
line 250, in run_command
  output = process.communicate(string_to_communicate)[0]
File:
"/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/subprocess.py",
line 661, in communicate
  stdout = self.stdout.read()

# Thread: -1341648896
File:
"/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/threading.py",
line 460, in __bootstrap
  self.run()
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 258, in run
  self._run(test_runner=None, result_summary=None)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 330, in _run
  result = self._run_test(test_info)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 439, in _run_test
  output, error)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py",
line 107, in process_output
  configuration)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py",
line 109, in compare_output
  print_text_diffs=True)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/test_types/test_type_base.py",
line 201, in write_output_files
  self._write_into_file_at_path(diff_filename, diff, encoding=None)
File:
"/b/slave/webkit-rel-mac-webkit-org/build/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/test_types/test_type_base.py",
line 160, in _write_into_file_at_path
  file.write(contents)


One thread is waiting for a response from pretypatch.  The other thread is hung
writing the results from running "diff" at:
        self._write_into_file_at_path(diff_filename, diff, encoding=None)

_write_file_into_path calls "codecs.open(..., encoding=encoding)". 
enoding=None just calls through to __builtin__.open(), so this should be no
different from writing any other file.

It's certainly possible that prettypatch got wedged and never print anything. 
Not sure.

This also could just be a symptom of whatever python bug is causing bug 38300.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.