[Webkit-unassigned] [Bug 38468] REGRESSION: Text clipped in absolutely positioned search inputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38468


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54974|                            |review?
               Flag|                            |




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2010-05-03 16:53:40 PST ---
Created an attachment (id=54974)
 --> (https://bugs.webkit.org/attachment.cgi?id=54974)
[PATCH] Quick Fix

This is just a quick fix to the issue. This matches RenderButton's
implementation. It is rect containing the contents (with padding but without
borders).

Dan Bernstein also raised a good question:

  I think the clip rect is essential for when the field height is less than the
  text height. I just don’t know why it isn’t applied to non-search fields
  just as well.

This patch does not address those issues, only fixing my mistake.

I could add a patch to this test, but I think this was just fixing the blunder
on my part. But, if a test is desired I could modify the attached test and add
another pixel test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.