[Webkit-unassigned] [Bug 38486] Maui MiniBrowser: Add an option to show/hide the web view
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 3 14:22:32 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=38486
Adam Roben (aroben) <aroben at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54960|review? |review+
Flag| |
--- Comment #2 from Adam Roben (aroben) <aroben at apple.com> 2010-05-03 14:22:32 PST ---
(From update of attachment 54960)
> + * MiniBrowser/win/BrowserWindow.cpp:
> + (BrowserWindow::createWindow):
> + (BrowserWindow::onCommand):
> + * MiniBrowser/win/MiniBrowser.rc:
> + * MiniBrowser/win/resource.h:
More details, please!
> + case ID_DEBUG_SHOW_WEB_VIEW: {
> + HMENU menu = ::GetMenu(m_window);
> + bool isChecked = ::GetMenuState(menu, ID_DEBUG_SHOW_WEB_VIEW, MF_BYCOMMAND) & MF_CHECKED;
I would call this variable shouldHide. Or reverse it and call it shouldShow.
r=me
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list