[Webkit-unassigned] [Bug 30958] Turn on warnings for QtWebKit for gcc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30958


Thiago Macieira <thiago.macieira at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thiago.macieira at nokia.com




--- Comment #6 from Thiago Macieira <thiago.macieira at nokia.com>  2010-05-03 05:32:14 PST ---
-Wcast-align needs to be removed.

With GCC 4.4, these two warning crops up all the time on ARM:

webkit/JavaScriptCore/wtf/Vector.h:484: warning: cast from
'WTF::AlignedBufferChar*' to '<insert type here>*' increases required alignment
of target type
webkit/JavaScriptCore/wtf/ListHashSet.h:174: warning: cast from 'char*' to
'WTF::ListHashSetNode<insert type here>*' increases required alignment of
target type

I know that WTF::Vector aligns by construction, but GCC doesn't know it. And
there's no way to tell it.

This option also triggers the warning in Qt code:
src/corelib/kernel/qobject.h:453: warning: cast from 'QObject*' to 'const
WebCore::GraphicsLayerQtImpl*' increases required alignment of target type
src/corelib/tools/qmap.h:180: warning: cast from 'char*' to 'QMapNode<float,
WebCore::KeyframeValueQt<WebCore::TransformOperations> >*' increases required
alignment of target type

In both cases the pointers are properly aligned for the type at hand.

The one thing in common between these four places is the use of
reinterpret_cast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.