[Webkit-unassigned] [Bug 38454] New: svn-apply: Have parseDiffHeader() call parseGitDiffHeader().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38454

           Summary: svn-apply: Have parseDiffHeader() call
                    parseGitDiffHeader().
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cjerdonek at webkit.org
                CC: dbates at webkit.org


In this patch, I think it would make sense to recast the existing
parseDiffHeader() as parseSvnDiffHeader() and then create a new
parseDiffHeader() that calls the Git or SVN version based on the first line
(whether it begins with "Index:" or "diff --git").  The unit tests for the new
parseDiffHeader() can have enough tests just to ensure that it supports
carrying over each diffHash key value correctly (since the more thorough tests
will be in the tests for the Git and SVN versions).

This patch can also delete the gitdiff2svndiff() subroutine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.