[Webkit-unassigned] [Bug 38434] Use HTML5 number parsing in HTMLProgressElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38434


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54878|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-05-02 23:50:28 PST ---
(From update of attachment 54878)
> +        Use parseToDoubleForNumberType instead of toDouble.

Where are the tests for the behavior changes this creates? We require tests for
any bug fixes. Or is this refactoring only?

> +        Throw an exception when the number is NaN or Infinity.

All the test changes seem to be for this independent half of the patch.

> +    if (isnan(value) || !isfinite(value)) {

The isnan check here is redundant and should be removed. The isfinite function
returns false for NAN.

review- because of a lack of test for the HTML5 number parsing change and
because the extra check should be omitted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.