[Webkit-unassigned] [Bug 38146] document.write is not synchronous

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38146


Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54345|review?                     |review+
               Flag|                            |




--- Comment #7 from Maciej Stachowiak <mjs at apple.com>  2010-05-01 17:41:05 PST ---
(From update of attachment 54345)
Code change looks good, but I have two suggestions for improving this patch:

1) it would probably be good to mention the external script exception to
synchronous behavior in the ChangeLog
2) it would be good to add a test case, even if it only  fails part of the time
in the bad case, or even if it is a manual test

r- for now for the lack of test. I'll gladly r+ if the points above are
addressed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.