[Webkit-unassigned] [Bug 38423] Add infrastructure to handle executable bit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38423





--- Comment #3 from Chris Jerdonek <cjerdonek at webkit.org>  2010-05-01 15:00:34 PST ---
(In reply to comment #2)
> Created an attachment (id=54857)
 --> (https://bugs.webkit.org/attachment.cgi?id=54857) [details]

> +++ WebKitTools/Scripts/VCSUtils.pm	(working copy)

> +sub toggleExecutableBit
> +{
> +    my ($path, $executableBitDelta) = @_;

I would rename this to something like "scmToggleExecutableBit" to indicate that
this method is setting the executable bit in the source control sense.

Also, I would document that this method does not error out if the file
corresponding to $path does not exist.

> +++ WebKitTools/Scripts/svn-apply	(working copy)
> +    if (!$addition && !$deletion && !$isBinary && !$isGitBinary && !defined($diffHashRef->{executableBitDelta})) {

Should you leave this line unchanged to allow the patch to apply?

> +++ WebKitTools/Scripts/svn-unapply	(working copy)
> +    if (!$addition && !$deletion && !$isBinary && !defined($diffHashRef->{executableBitDelta})) {

Should you leave this line unchanged to allow the patch to apply?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.