[Webkit-unassigned] [Bug 35781] New: check-webkit-style: --git-commit is incompatible with prepare-ChangeLog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35781

           Summary: check-webkit-style: --git-commit is incompatible with
                    prepare-ChangeLog
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yutak at chromium.org
                CC: hamaji at chromium.org


check-webkit-style --git-commit=HEAD doesn't check any files (assuming there's
no local edit in the index). When you want to check the most recent commit, you
need to pass --git-commit=HEAD^.

$ ./check-webkit-style --git-commit=HEAD
Total errors found: 0 in 0 files

This behavior is not compatible with prepare-ChangeLog; when it is given
--git-commit=FOO, it edits ChangeLog using commits from FOO^, not from FOO. The
following code snippet took from prepare-ChangeLog describes the behavior well:

sub diffFromToString()
{
    return "" if $isSVN;
    return $gitCommit if $gitCommit =~ m/.+\.\..+/;
    return "\"$gitCommit^\" \"$gitCommit\"" if $gitCommit;
    return "--cached" if $gitIndex;
    return "HEAD" if $isGit;
}

It's easy to misuse current --git-commit option of check-webkit-style. I think
it should mimic the behavior of prepare-ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.