[Webkit-unassigned] [Bug 35723] Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35723


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50075|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2010-03-04 18:44:25 PST ---
(From update of attachment 50075)
> +static bool hasMultibyteCharacters(const String& string)
> +{
> +    for (unsigned i = 0; i < string.length(); i++) {
> +        if (string[i] > 0xFF)
> +            return true;
> +    }
> +
> +    return false;
> +}

This is not a great name for this function. I don’t really think of U+0040 as a
“single byte” character nor do I think of U+0100 as “multi-byte”.

Patch otherwise seems OK.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.