[Webkit-unassigned] [Bug 35775] [chromium linux] Improve look of scrollbars

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35775


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-03-04 17:55:01 PST ---
Attachment 50072 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:182:  Boolean
expressions that span multiple lines should have their operators on the left
side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:182:  Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:187:  track_hsv is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:189:  button_color is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:190: 
background_color is incorrectly named. Don't use underscores in your identifier
names.  [readability/naming] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:192:  button_hsv is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:196:  button_hsv is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:251:  thumb_hsv is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.