[Webkit-unassigned] [Bug 35755] [Qt] QtLauncher needs an option to toggle FullScreen Mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35755





--- Comment #4 from Jesus Sanchez-Palencia <jesus.palencia at openbossa.org>  2010-03-04 14:06:02 PST ---
(In reply to comment #2)
> (From update of attachment 50038 [details])
> Overall looks good.
> 
> > +signals:
> > +    void fullscreen(bool on);
> 
> Usually signal name is future (aboutToDoFoo) or past (foobarHasChanged).

Ok, changed this.

> 
> > +    // If click pos is the bottom right corner (square with size defined by gExitClickArea)
> > +    // and the window is on FullScreen, the window must return to its original state.
> > +    if (event->type() == QEvent::MouseButtonRelease) {
> > +        QMouseEvent* ev = static_cast<QMouseEvent*>(event);
> > +        if (windowState() == Qt::WindowFullScreen
> > +            && ev->pos().x() > (size().width() - gExitClickArea)
> > +            && ev->pos().y() > (size().height() - gExitClickArea)) {
> 
> Using width() and height() directly does not work?

Yes, indeed! Fixed.

> 
> > +    toggleFullScreen->connect(this, SIGNAL(fullscreen(bool)), SLOT(setChecked(bool)));
> 
> Is this a correct connection?

Yes. This is to handle when you exit FullScreen mode by clicking on the "exit
area" (bottom right corner), until we have a nice fullscreen button to go
there.
I've added a comment to the patch so this won't confuse anyone in the future.

thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.