[Webkit-unassigned] [Bug 35368] Frame should use SelectionController's TextGranularity instead of its own

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35368





--- Comment #9 from Ojan Vafai <ojan at chromium.org>  2010-03-04 12:08:02 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > With this patch, a shouldChangeSelectedDOMRange delegate method is being
> > called, but a subsequent webViewDidChangeSelection one no longer is. This is
> > quite suspicious, and perhaps it violates what can be considered an invariant
> > in the API.
> 
> OK. I'll look into this more.

This is not currently an invariant of the API. Anytime
SelectionController::setSelection early returns, we'd see this mismatch. In
this case, this patch hits an early return at line 141 of
SelectionController.cpp. Since the granularity is no longer a member of the
VisibleSelection, the selection itself is not actually changing.

I'm attaching an example test that also has this mismatch and hits the same
early return on a clean trunk build (single click in the same spot twice).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.