[Webkit-unassigned] [Bug 35755] [Qt] QtLauncher needs an option to toggle FullScreen Mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35755


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50038|review?                     |review-
               Flag|                            |




--- Comment #2 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-03-04 11:34:43 PST ---
(From update of attachment 50038)
Overall looks good.

> +signals:
> +    void fullscreen(bool on);

Usually signal name is future (aboutToDoFoo) or past (foobarHasChanged).

> +    // If click pos is the bottom right corner (square with size defined by gExitClickArea)
> +    // and the window is on FullScreen, the window must return to its original state.
> +    if (event->type() == QEvent::MouseButtonRelease) {
> +        QMouseEvent* ev = static_cast<QMouseEvent*>(event);
> +        if (windowState() == Qt::WindowFullScreen
> +            && ev->pos().x() > (size().width() - gExitClickArea)
> +            && ev->pos().y() > (size().height() - gExitClickArea)) {

Using width() and height() directly does not work?

> +    toggleFullScreen->connect(this, SIGNAL(fullscreen(bool)), SLOT(setChecked(bool)));

Is this a correct connection?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.