[Webkit-unassigned] [Bug 35630] Refactoring: XMLHTTPRequest.open() should have all overloaded implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35630


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49992|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #15 from Alexey Proskuryakov <ap at webkit.org>  2010-03-04 10:39:36 PST ---
(From update of attachment 49992)
> +PASS: if async argument is something defined, send() should behave like as async=true

This is not what the current code implements. The argument is converted to
boolean, so e.g. null or "" become false.

Please change "if async argument is something defined, send() should behave
like as async=true" to "if async argument is a non-empty string, send() should
behave like as async=true", because that's what the subtest verifies. One can
make this change when landing, or you could submit a new patch if you want to
use commit-queue.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.