[Webkit-unassigned] [Bug 35146] [Qt] Support tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35146





--- Comment #23 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-04 10:20:57 PST ---
(From update of attachment 50032)
> +    int h = views[0]->horizontalScrollBar()->value();
> +    int v = views[0]->verticalScrollBar()->value();

These return the size? or ? 

> +#if ENABLE(TILED_BACKING_STORE)
> +    if (!frame->tiledBackingStore())
> +#endif
> +        view->layoutIfNeededRecursive();

I prefer adding an #else in this case

#if ENABLE(TILED_BACKING_STORE)
    if (!frame->tiledBackingStore())
         view->layoutIfNeededRecursive();
#else
    view->layoutIfNeededRecursive();
#endif

> +#if ENABLE(TILED_BACKING_STORE)
> +        if (frame->tiledBackingStore())
> +            frame->tiledBackingStore()->paint(context, clipRect);
> +        else
> +#endif
> +            view->paintContents(context, clipRect);

Same here.

> Index: WebKit/qt/QGVLauncher/main.cpp

QGVLauncher was removed from trunk!


> +    toggleResizesToContents->setCheckable(true);
> +    toggleResizesToContents->setChecked(false);
> +    toggleResizesToContents->setEnabled(false);

I guess here is should check the setting to find out if it is actually enabled
or not. Such a change was done to the other toggles by Jesus. I was told that
that change had gone in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.