[Webkit-unassigned] [Bug 34936] [Chromium] Typing into Flash with wmode = opaque|transparent and non-latin language active outputs as if US keyboard layout active

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34936





--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-04 10:06:11 PST ---
(From update of attachment 50002)
> Index: WebKit/chromium/src/WebViewImpl.cpp
> ===================================================================
> --- WebKit/chromium/src/WebViewImpl.cpp	(revision 55511)
> +++ WebKit/chromium/src/WebViewImpl.cpp	(working copy)
> @@ -507,8 +507,13 @@ bool WebViewImpl::keyEvent(const WebKeyb
>      PlatformKeyboardEventBuilder evt(event);
>  
>      if (handler->keyEvent(evt)) {
> -        if (WebInputEvent::RawKeyDown == event.type)
> -            m_suppressNextKeypressEvent = true;
> +        if (WebInputEvent::RawKeyDown == event.type) {
> +            // Suppress the next keypress event unless the focused node is a plug-in node.
> +            // (Flash needs these keypress events to handle non-US keyboards.)
> +            Node* node = frame->document()->focusedNode();
> +            if (!node || !node->renderer()->isEmbeddedObject())

You might need to null check node->renderer() before de-referencing it.
Most code does so.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.