[Webkit-unassigned] [Bug 35703] Add support for DOM Level 3 Custom Event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 4 04:28:00 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35703





--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-04 04:28:00 PST ---
(In reply to comment #4)
> This patch adds CustomEvent.idl to build files, but I don't see it actually
> being added.  Am I missing something?

I much have misses it when I redid the patch.

> In terms of changes in WebCore/bindings/v8/, the following changes are needed:
> 1. Add CustomEvent.h to DOMObjectsInclude.h
> 2. Add a line for CustomEvent to macros in V8Index.h
> 3. Add a downcast to toV8() in custom/V8EventCustom.cpp, very much analogous to
> the change in bindings/js/JSEventCustom.cpp.
> 
> In theory, the V8 bindings should Just Work with those changes.

Great! I'll do it! Thanks for the explanation.

> One more question: I notice CustomEvent takes a DOMObject* in its constructor
> and as a private member.  It looks to me like that class is defined in
> bindings/js/JSDOMWrapper.h.  Is that right?

DOMObject is defined in JSDOMWrapper.h, yes. Maybe we need some more V8 changes
because of this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list