[Webkit-unassigned] [Bug 34936] [Chromium] Typing into Flash with wmode = opaque|transparent and non-latin language active outputs as if US keyboard layout active

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34936


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49269|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-03 23:18:12 PST ---
(From update of attachment 49269)
> Index: WebKit/chromium/src/WebViewImpl.cpp
...
> @@ -507,8 +507,13 @@ bool WebViewImpl::keyEvent(const WebKeyb
>      PlatformKeyboardEventBuilder evt(event);
>  
>      if (handler->keyEvent(evt)) {
> -        if (WebInputEvent::RawKeyDown == event.type)
> -            m_suppressNextKeypressEvent = true;
> +        if (WebInputEvent::RawKeyDown == event.type) {
> +            // Suppress the next keypress event unless the focused node is a plug-in node.
> +            // (Flash needs these keypress events to handle non-US keyboards.)
> +            Node* node = frame->document()->focusedNode();
> +            if (!node || (!node->hasTagName(HTMLNames::embedTag) && !node->hasTagName(HTMLNames::objectTag)))

An <object> tag can be more than just a plug-in.  It would
probably be better check the renderer to see if it is a plug-in
via node->renderer()->isEmbeddedObject().

Otherwise, I think this change is good.  Nice work on the test!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.