[Webkit-unassigned] [Bug 35368] Frame should use SelectionController's TextGranularity instead of its own

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 18:45:50 PST 2010


--- Comment #7 from Ojan Vafai <ojan at chromium.org>  2010-03-03 18:45:49 PST ---
(In reply to comment #6)
> With this patch, a shouldChangeSelectedDOMRange delegate method is being
> called, but a subsequent webViewDidChangeSelection one no longer is. This is
> quite suspicious, and perhaps it violates what can be considered an invariant
> in the API.

OK. I'll look into this more.

> VisibleSelection is a member if EditCommand, used for restoring selection after
> undo/redo. This patch looks like it actually changes behavior, so that
> selection granularity isn't restored. Is this indeed the case?

I didn't think about this case. It turns out that our current behavior doesn't
match TextEdit anyways. TextEdit, as best I can tell, always uses
CharacterGranularity after an undo, but it selects the space that got smart
deleted. I've filed a patch at bug 35713 to fix that. Then this problem goes
away. :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list