[Webkit-unassigned] [Bug 35634] [DRT/Chromium] Add CppVariant and CppBoundClass
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 3 18:12:02 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=35634
--- Comment #4 from TAMURA, Kent <tkent at chromium.org> 2010-03-03 18:12:01 PST ---
(In reply to comment #2)
> (From update of attachment 49892 [details])
> Minor comments overall. Do you think Cpp* prefix on these classes makes any
> sense in the context of DRT? I am having naming doubts, but can't come up with
> anything better. Maybe fishd would have some ideas.
Cpp* is not so meaningful, but I feel it is not bad.
> > +// Copyright (c) 2010 The Chromium Authors. All rights reserved.
> > +// Use of this source code is governed by a BSD-style license that can be
> > +// found in the LICENSE file.
>
> Incorrect license header. Please use standard WebKit header.
These files have changes by non-Googler. What header should we add? Just
replace "Google Inc" with "The Chromium Authors" in the usual header?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list