[Webkit-unassigned] [Bug 35630] Refactoring: XMLHTTPRequest.open() should have all overloaded implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35630





--- Comment #9 from Yaar Schnitman <yaar at chromium.org>  2010-03-03 17:31:25 PST ---
http://www.w3.org/TR/XMLHttpRequest/#the-open-method says that the default for
async is true. However, when async is passed, anything other then JS true
should be treated as false. You should omit the !args.at(2).isUndefined()
checks to achieve that effect.

(In reply to comment #8)
> (From update of attachment 49886 [details])
> +        No new tests. No functional change.
> 
> This is not accurate. This patch changes the behavior of open("GET", url,
> undefined) - we used to treat the last argument as false, and now it's true.
> This may or may not be desired, depending on what the spec says, and what other
> browsers do. It also changes the behavior of open("GET", url, undefined, user,
> password), in a way that seems clearly incorrect.
> 
> Regardless of whether you decide to keep or drop this change, please add a
> regression test that would have caught it.
> 
> An existing test xmlhttprequest/basic-auth.html covers undefined and missing
> values for user/password, and the patch seems to be fine in this regard.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.