[Webkit-unassigned] [Bug 35695] Move files from WebCore/platform/graphics/gtk to ../cairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35695





--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-03-03 13:25:48 PST ---
Attachment 49938 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
 [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:99:  Use 0 instead of
NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:103:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:115:  Use 0 instead
of NULL.  [readability/null] [4]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:150:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:155:  Use 0 instead
of NULL.  [readability/null] [4]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:247:  Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:248:  Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:48:  font_extents is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:49:  text_extents is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:101:  Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:126:  Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons.  [readability/comparison_to_zero] [5]
WARNING: Could not read file. Skipping:
"WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp"
WebCore/platform/graphics/cairo/FontCacheCairo.cpp:43:  Use 0 instead of NULL. 
[readability/null] [5]
WebCore/platform/graphics/cairo/FontCacheCairo.cpp:48:  Use 0 instead of NULL. 
[readability/null] [5]
WebCore/platform/graphics/cairo/FontCustomPlatformData.h:27:  cairo_font_face_t
is incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp:25:  Alphabetical
sorting problem.  [build/include_order] [4]
WARNING: Could not read file. Skipping:
"WebCore/platform/graphics/gtk/FontPlatformData.h"
WebCore/platform/graphics/cairo/FontPlatformData.h:32:  Alphabetical sorting
problem.  [build/include_order] [4]
WebCore/platform/graphics/cairo/FontPlatformData.h:104:  Place brace on its own
line for function definitions.  [whitespace/braces] [4]
WARNING: Could not read file. Skipping:
"WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp"
WARNING: Could not read file. Skipping:
"WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp"
WARNING: Could not read file. Skipping:
"WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp"
WARNING: Could not read file. Skipping:
"WebCore/platform/graphics/gtk/FontCacheGtk.cpp"
Total errors found: 20 in 16 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.