[Webkit-unassigned] [Bug 35583] if font-family lists several generic families, the last one takes precedence

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 00:59:15 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35583





--- Comment #4 from Olivier Tilloy <olivier at tilloy.net>  2010-03-03 00:59:16 PST ---
Thanks for your feedback Alexey.
It looks like the bug I'm trying to fix is indeed platform-specific. Since I
could reproduce it on the GTK and QT ports on linux, I assumed a bit too fast
it was general.

Still, I believe the first part of my analysis and the patch are valid, as far
as I can interpret the specification and understand the CSSStyleSelector code
correctly. I can't think of an obvious layout test for it though.

If anyone who knows better this part of the code could take a look into it, it
would be much appreciated! If my change makes sense I'll gladly generate a
suitable patch with the Changelog.


As far as the layout test I attached is concerned, my guess is that ports that
do the right thing (like the mac one) iterate over the list of families,
discarding the first one as invalid and falling back on the second one
("-webkit-monospace"), whereas the GTK port seems to always generate a font
from the first family, using the family name and falling back to the font
description's generic family (which explains why this patch seems to fix it).
I will file a separate bug for the GTK port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list