[Webkit-unassigned] [Bug 34082] [Android] Android Geolocation service should not start if the WebView is paused

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34082





--- Comment #20 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-03-02 14:29:22 PST ---
(In reply to comment #19)
> > The iPhone port overrides methods that already exist on ScriptExecutionContext
> > to suspend and resume Geolocation services:  suspendActiveDOMObjects(),
> > resumeActiveDOMObjects() and stopActiveDOMObjects().
> Do you mean that the iPhone overloads these methods in Document, or in another
> class that extends ScriptExecutionContext? These methods on Document are called
> from several places, so I'm not sure it's safe to override them.

Yes, it overloads them, but calls the overridden method on
ScriptExecutionContext:: before doing its own work.

> > Document extends
> > ScriptExecutionContext, so this seemed like a natural place for them.
> Or did you mean that we should add new suspend and resume methods to Document?

I don't have a strong opinion here.  You have to walk the frame tree to find
each Document no matter where you do it, so maybe it makes more sense to do it
in Page than somewhere in each platform's WebKit implementation.

> Another option would be to make Geolocation inherit from ActiveDOMObject, so it
> could be suspended and resumed by the calls to the existing
> ScriptExecutionContext methods.

I like this option best (if it makes sense architecturally)!  Then you get the
desired behavior for "free" by using existing API.  I am not the right person
to ask if it makes sense, though, as I'm not intimately familiar with the
concepts involved.  Sam Weinig may have an opinion on this approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.