[Webkit-unassigned] [Bug 35565] Google Analytics triggers "blocked plugin" UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35565





--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-03-02 09:32:50 PST ---
> nit: gratuitous const :)

Removed.

> ^^^ maybe this should go in FrameLoaderTypes.h?

Done.

> > +++ b/WebCore/loader/MainResourceLoader.cpp
> ...
> > +    if (!m_frame->loader()->allowPlugins(NowAboutToInstantiatePlugin))
> 
> NowAboutToInstantiatePlugin -> AboutToInstantiatePlugin, right?

"Now" is a typo.  I think it's supposed to be "Not".

> instanitated -> instantiated

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.