[Webkit-unassigned] [Bug 35565] Google Analytics triggers "blocked plugin" UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35565


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49784|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-02 00:27:36 PST ---
(From update of attachment 49784)
Thanks for working on this!  Just some minor issues:


> +++ b/WebCore/loader/FrameLoader.cpp

> +    const bool allowed = m_client->allowPlugins(settings && settings->arePluginsEnabled());

nit: gratuitous const :)


> +++ b/WebCore/loader/FrameLoader.h
> @@ -82,6 +82,11 @@ class Widget;
>  struct FrameLoadRequest;
>  struct WindowFeatures;
>  
> +enum ReasonForCallingAllowPlugins {
> +    AboutToInstantiatePlugin,
> +    NotAboutToInstantiatePlugin
> +};

^^^ maybe this should go in FrameLoaderTypes.h?


> +++ b/WebCore/loader/MainResourceLoader.cpp
...
> +    if (!m_frame->loader()->allowPlugins(NowAboutToInstantiatePlugin))

NowAboutToInstantiatePlugin -> AboutToInstantiatePlugin, right?


> +++ b/WebKit/chromium/public/WebFrameClient.h

> +    // Notifies the client that the frame would have instanitated a plug-in if plug-ins were enabled.

instanitated -> instantiated

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.