[Webkit-unassigned] [Bug 35551] New: Hardcoding of /usr/bin/gcc in perl build scripts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35551

           Summary: Hardcoding of /usr/bin/gcc in perl build scripts
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: Fred_Ollinger at seektech.com



Fred Ollinger <Fred_Ollinger at seektech.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49760|                            |review+, commit-queue+
               Flag|                            |


Created an attachment (id=49760)
 --> (https://bugs.webkit.org/attachment.cgi?id=49760)
Patch to change /usr/bin/gcc to $ENV{CC} in perl build scripts.

Recently when trying to cross the nightly build: r55354, I noticed that several
Perl scripts hardcoded the path to /usr/bin/gcc. Obviously, this completely
breaks a cross compile as a cross compiler should not be installed in
/usr/bin/gcc; that's where the native compiler is NOT the cross compiler. 

There are four perl build scripts that hard code /usr/bin/gcc as the default
compiler. This is true even if one has chosen to cross-compile. This should
effectively break cross-compiling as there is no way to tell ./configure that
gcc is located in an alternate location. This bug will also break use of
another compiler other than gcc. It will also break using a different version
of gcc if it is not installed in the default location of /usr/bin/gcc.

To fix this, I first isolated the areas where /usr/bin/gcc was called from
Perl. Then I changed references from "/usr/bin/gcc" to $ENV{CC} which will
allow a user to use any version of gcc that they wish. Patch is attached.


1. bindings/scripts/CodeGeneratorObjC.pm   

2. bindings/scripts/IDLParser.pm        

3. css/make-css-file-arrays.pl

4. dom/make_names.pl

Fred Ollinger
Embedded Software Engineer
Seektech, Incorporated
http://www.seektechinc.com/
fred_ollinger at seektech.com

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.