[Webkit-unassigned] [Bug 35530] Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 14:06:23 PST 2010


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #49727|review?                     |review-
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2010-03-01 14:06:23 PST ---
(From update of attachment 49727)
A change like this needs a comment. Having these #undef at the top of the file
with no comment is not good.

The extra blank line before the class definition is not wanted.

A better change would be to change these identifiers. There's no reason to use
all capitals for these. While the #undef will work it's probably not a major
project to simply change these to use normal mixed case as per the WebKit
coding guidelines.

review- because there needs to be a comment

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list