[Webkit-unassigned] [Bug 35210] [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35210


arno. <arno at renevier.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49676|0                           |1
        is obsolete|                            |




--- Comment #20 from arno. <arno at renevier.net>  2010-03-01 12:41:50 PST ---
Created an attachment (id=49738)
 --> (https://bugs.webkit.org/attachment.cgi?id=49738)
patch v2.7

updated patch:
fixes what's been pointed in the last two comments except one thing I did not
understood:

> >+typedef struct _WebKitGeolocationPolicyDecisionPrivate WebKitGeolocationPolicyDecisionPrivate;
> >+struct _WebKitGeolocationPolicyDecision {
> >+    GObject parent_instance;
> >+
> >+    /*< private >*/
> >+    WebKitGeolocationPolicyDecisionPrivate* priv;
> >+};
> >+
> >+struct _WebKitGeolocationPolicyDecisionClass {
> >+    GObjectClass parent_class;
> >+
> >+    /* Padding for future expansion */
> >+    void (*_webkit_reserved0) (void);
> >+    void (*_webkit_reserved1) (void);
> >+    void (*_webkit_reserved2) (void);
> >+    void (*_webkit_reserved3) (void);
> >+};
> 
> Should probably use camelCase for struct members.
> 
> Looks fine to me otherwise, r=1/2 me :)


are you talking about webkit_reservedX and parent_class ? because in every
other files in WebKit/gtk/webkit, case of those members is the same as the one
in my patch. So, should that be different in mine ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.