[Webkit-unassigned] [Bug 26927] webkit-patch or pre-commit hook should validate reviewer lines before committing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 12:17:54 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=26927


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #1 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-01 12:17:54 PST ---
If I land a patch through the commit-queue that has been reviewed, it could
fail if the ChangeLog says "Reviewed by NOBODY".

"Reviewed by NOBODY" is a valid line, but probably not the intention if the
patch was actually reviewed.

Personally I always write "Unreviewed" and then some kind of explanation, like
"Unreviewed Qt buildbot fix".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list